linux-kernel - Re: [rfc 2/3] fs, proc: Introduce the Children: line in /proc/<pid>/status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Dec 2011 19:53:30 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrew Vagin <avagin@...nvz.org>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [rfc 2/3] fs, proc: Introduce the Children: line in
 /proc/<pid>/status

On Thu, Dec 01, 2011 at 07:43:57AM -0800, Tejun Heo wrote:
> > +
> > +int proc_pid_children(struct seq_file *m, struct pid_namespace *ns,
> > +		      struct pid *pid, struct task_struct *task)
> > +{
> > +	struct task_struct *c;
> > +
> > +	read_lock(&tasklist_lock);
> > +	list_for_each_entry(c, &task->children, sibling)
> > +		seq_printf(m, " %d", pid_nr_ns(task_pid(c), ns));
> > +	read_unlock(&tasklist_lock);
> > +	seq_putc(m, '\n');
> > +
> > +	return 0;
> > +}
> 
> I don't think using non-seekable single seqfile is a good idea here.
> It works if the whole list fits in PAGE_SIZE but assuming five digit
> pid, that's only ~680 pids.
> 

Hi Tejun, indeed this is not pleasant limit, thanks for the point,
I'll update! But other than this technical detail, I assume there is
no objection from introducing such feature?

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/