linux-kernel - Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ED7BBA3.5020002@redhat.com>
Date:	Thu, 01 Dec 2011 15:38:43 -0200
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	HoP <jpetrous@...il.com>
CC:	Andreas Oberritter <obi@...uxtv.org>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because
 of worrying about possible misusage?

On 01-12-2011 12:58, HoP wrote:
> Hi,
>
> let me ask you some details of your interesting idea (how to
> achieve the same functionality as with vtunerc driver):
>
> [...]
>
>> The driver, as proposed, is not really a driver, as it doesn't support any
>> hardware. The kernel driver would be used to just copy data from one
>> userspace
>
> Please stop learning me what can be called driver and what nope.
> Your definition is nonsense and I don't want to follow you on it.
>
>> application to the other. The same result could be obtained in userspace,
>> by implementing a library. Such library could even use LD_PRELOAD to support
>> binary only applications, like what libv4l does. In terms of performance,
>> such library would probably perform better than a kernel driver, as there's
>> no need to do context switching for each call, and no need to talk with a
>> device (where kernel outperforms userspace). Also, depending on how such
>> library
>> is implemented, double buffering might be avoided.
>>
>> So, from architectural POV, this code should be written as an userspace
>> library.
>> BTW, alsa also came with the same results, years ago, as audio remote
>> streaming is supported via userspace tools, like pulseaudio.
>
> Can you show me, how then can be reused most important part
> of dvb-core subsystem like tuning and demuxing?

Why do you need to implement it? Just forward the requests to the machine
with the real driver.

> Or do you want me
> to invent wheels and to recode everything in the library?

Kernel code is GPLv2. You can use its code on a GPLv2 licensed library.

> Of course
> I can be wrong, I'm no big kernel hacker. So please show me the
> way for it. BTW, even if you can find the way, then data copying
> from userspace to the kernel and back is also necessery.

See libv4l, at v4l2-utils.git (at linuxtv.org).

> I really
> don't see any advantage of you solution.

And I can't see any advantage on yours ;) Putting something that belongs
to userspace into kernelspace just because it is easier to re-use the
existing code inside the kernel is not a good argument.

Don't get me wrong but if you want to submit a code to be merged
on any existing software (being open source or not), you should be
prepared to defend your code and justify the need for it to the
other developers.

Regards,
Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/