| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1322768576-9242-1-git-send-email-levinsasha928@gmail.com> Date: Thu, 1 Dec 2011 21:42:56 +0200 From: Sasha Levin <levinsasha928@...il.com> To: linux-kernel@...r.kernel.org Cc: Sasha Levin <levinsasha928@...il.com>, Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>, kvm@...r.kernel.org Subject: [PATCH] KVM: Veirfy memory slot only for readability It's enough for memory slot to be readable, as the comment above the check states. A user should be able to create read-only memory slot. Cc: Avi Kivity <avi@...hat.com> Cc: Marcelo Tosatti <mtosatti@...hat.com> Cc: kvm@...r.kernel.org Signed-off-by: Sasha Levin <levinsasha928@...il.com> --- virt/kvm/kvm_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index e289486..b92883f 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -727,7 +727,7 @@ int __kvm_set_memory_region(struct kvm *kvm, /* We can read the guest memory with __xxx_user() later on. */ if (user_alloc && ((mem->userspace_addr & (PAGE_SIZE - 1)) || - !access_ok(VERIFY_WRITE, + !access_ok(VERIFY_READ, (void __user *)(unsigned long)mem->userspace_addr, mem->memory_size))) goto out; -- 1.7.8.rc4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists