linux-kernel - Re: [PATCH] init/do_mounts.c : Create /root if it does not exits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ED6C939.9050403@gmail.com>
Date:	Wed, 30 Nov 2011 19:24:25 -0500
From:	Woody Suwalski <terraluna977@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	yanhong <tempname2@...mail.com>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] init/do_mounts.c : Create /root if it does not exits

Andrew Morton wrote:
> On Sat, 26 Nov 2011 08:34:18 +0000
> yanhong<tempname2@...mail.com>  wrote:
>
>> From: YanHong<tempname2@...mail.com>
>>
>> If someone supplies an initramfs without /root in it, and we fail to execute rdinit, we will try to mount root device and fail, for the mount point does not exits.
>>
>> But we get error message "VFS: Cannot open root device". It's confusing.
>>
>> We can give more detailed error message, or we can go further: if /root does not exits,  create one.
>>
> I really don't know enough about initramfs usage to know if this is a
> good or bad thing.  Can anyone else comment?
>
>> --- a/init/do_mounts.c
>> +++ b/init/do_mounts.c
>> @@ -350,6 +350,9 @@ void __init mount_block_root(char *name, int flags)
>>          const char *b = name;
>>   #endif
>>
>> +       if (sys_access((const char __user *) "/root", 0) != 0)
>> +               sys_mkdir((const char __user *) "/root", 0700);
>> +
>>          get_fs_names(fs_names);
>>   retry:
>>          for (p = fs_names; *p; p += strlen(p)+1) {
> I suppose we could remove the sys_access() check and just run mkdir(),
> which will fail to do anything if /root already exists.
>
I think that it may lead to more problems... If I make mistake in the 
initramfs or forget to make one I want to know about it, rather then see 
some unexpected root and system maybe partially booting.
Unless we start printing a highly visible warning along? Still - it is 
cleaner to simply stop boot (IMHO).

Woody

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/