linux-kernel - RE: [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Dec 2011 17:43:37 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Marc Zyngier' <marc.zyngier@....com>,
	'Axel Lin' <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	'Russell King' <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org
Subject: RE: [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset'
 undeclared

Marc Zyngier wrote:
> 
> On 01/12/11 15:24, Axel Lin wrote:
> > Fix below build error:
> >   CC      arch/arm/mach-exynos/cpu.o
> > arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
> > arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared
> (first use in this function)
> > arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is
> reported only once
> > arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
> > arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
> > make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
> > make: *** [arch/arm/mach-exynos] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> 
> Arghhh... My bad. Thanks for fixing that.
> 
> Acked-by: Marc Zyngier <marc.zyngier@....com>
> 
Hi Marc,

Since the commit 4e44d2cb("ARM: exynos4: convert to CONFIG_MULTI_IRQ_HANDLER") is not in my tree, this should be handled in your tree and Axel's patch, "ARM: exynos4: Fix build error" is too.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> > ---
> >  arch/arm/mach-exynos/cpu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
> > index fed62f4..c7cb462 100644
> > --- a/arch/arm/mach-exynos/cpu.c
> > +++ b/arch/arm/mach-exynos/cpu.c
> > @@ -240,7 +240,7 @@ static const struct of_device_id
> exynos4_dt_irq_match[] = {
> >  void __init exynos4_init_irq(void)
> >  {
> >  	int irq;
> > -	unsigned int bank_offset;
> > +	unsigned int gic_bank_offset;
> >
> >  	gic_bank_offset = soc_is_exynos4412() ? 0x4000 : 0x8000;
> >
> 
> 
> --
> Jazz is not dead. It just smells funny...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/