linux-kernel - Re: [PATCH] x86: fix error paths in microcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111202152403.GB16690@gere.osrc.amd.com>
Date:	Fri, 2 Dec 2011 16:24:03 +0100
From:	Borislav Petkov <bp@...64.org>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Cc:	Jan Beulich <JBeulich@...e.com>, mingo@...e.hu, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH] x86: fix error paths in microcode_init()

On Fri, Dec 02, 2011 at 08:45:09PM +0530, Srivatsa S. Bhat wrote:
> Your patch fixes the issue more properly than mine, but adding your part
> on top of my patch makes the code look better. For example,
> platform_device_unregister() wouldn't need to be called twice; and we 
> can use the quite popular way of handling error path via goto statements,
> which makes the code flow much more comprehensible and intuitive.

Yes,

goto labels is the proper way for spelling error handling in the kernel
so I could very well take your patch Jan, instead, if you change it to
use goto labels for the error path as Srivatsa's patch does it. That is,
in case Ingo hasn't pulled yet.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/