[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+55aFzUy2C26GbTqapEgh0wh5Z1wuH_-Kdm7yCdp6cnu46afQ@mail.gmail.com>
Date: Fri, 2 Dec 2011 14:40:37 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Anton Vorontsov <anton.vorontsov@...aro.org>
Cc: Dave Martin <dave.martin@...aro.org>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Andrew Morton <akpm@...ux-foundation.org>,
devicetree-discuss@...ts.ozlabs.org,
LKML <linux-kernel@...r.kernel.org>, linux-ide@...r.kernel.org,
Randy Dunlap <rdunlap@...otime.net>,
linux-next@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
Jeff Garzik <jgarzik@...hat.com>
Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
On Fri, Dec 2, 2011 at 2:34 PM, Anton Vorontsov
<anton.vorontsov@...aro.org> wrote:
>
> One option is to test this patch on a board that is now broken:
>
> http://lkml.org/lkml/2011/11/10/290
That seems broken.
Spot the trouble:
+ ret = irq_create_of_mapping(oirq.controller, oirq.specifier,
+ oirq.size);
+no_irq:
+#ifdef NO_IRQ
+#if NO_IRQ != 0
+ if (ret == NO_IRQ)
+ pr_warn("Hit NO_IRQ case for your arch. Drivers might expect "
+ "NO_IRQ, but we return 0. If anything breaks, driver "
+ "have to be fixed.\n");
+#endif
+#endif
+ return ret;
It claims "we return 0", but then doesn't return zero.. Hmm?
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists