linux-kernel - Re: [RFC PATCH V2 0/1] making order in file2alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mxbaqmu8.fsf@rustcorp.com.au>
Date:	Sat, 03 Dec 2011 15:21:43 +1030
From:	Rusty Russell <rusty@...abs.org>
To:	Greg KH <greg@...ah.com>, Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org, siglesia@...n.ch,
	manohar.vanga@...n.ch, dave.martin@...aro.org
Subject: Re: [RFC PATCH V2 0/1] making order in file2alias

On Fri, 2 Dec 2011 11:27:01 -0800, Greg KH <greg@...ah.com> wrote:
> On Fri, Dec 02, 2011 at 09:42:13AM +0100, Alessandro Rubini wrote:
> > > But splitting 15-line functions into separate files?  Less compact, less
> > > simple.
> > 
> > Personally, I'm more interested in the addition of new busses (as
> > drop-in files) than the split up of current ones. But I see your point.
> 
> Yes, that's what me and Linus have asked about having in the past,
> making things easier to merge and the like.  Now admittedly, this file
> isn't all that hard to merge these days given that the addition of new
> busses is pretty rare, these complaints might have been from before git
> times, when merges were harder than they are now.
> 
> Anyway, I like your patch as well, as it seems to get us to that goal.

But it doesn't :( Trivial conflict in file2alias.c becomes trivial
conflict in Makefile.

We could use $(wildcard) in the Makefile, but that's not used much in
the kernel so it'd seem a bit weird.

So honestly, I think we should reorder file2alias.c into alphabetical
order.  In practice, that'll prevent conflicts.

As I said, I'm happy for Alessandro to do the separate file thing *too*,
but if that was the only point, there wasn't one.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/