linux-kernel - Re: [PATCH] vmwgfx: Use kcalloc instead of kzalloc to allocate array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 5 Dec 2011 02:06:46 -0800 (PST)
From:	Jakob Bornecrantz <jakob@...are.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vmwgfx: Use kcalloc instead of kzalloc to allocate
 array

Reviewed-by: Jakob Bornecrantz <jakob@...are.com>

----- Original Message -----
> The advantage of kcalloc is, that will prevent integer overflows
> which could result from the multiplication of number of elements
> and size and it is also a bit nicer to read.
> 
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
> 
> diff -u -p a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c 2011-11-13
> 11:07:24.343455126 +0100
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c 2011-11-28
> 19:50:07.413502824 +0100
> @@ -140,7 +140,7 @@ int vmw_present_ioctl(struct drm_device
>  		goto out_clips;
>  	}
>  
> -	clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL);
> +	clips = kcalloc(num_clips, sizeof(*clips), GFP_KERNEL);
>  	if (clips == NULL) {
>  		DRM_ERROR("Failed to allocate clip rect list.\n");
>  		ret = -ENOMEM;
> @@ -232,7 +232,7 @@ int vmw_present_readback_ioctl(struct dr
>  		goto out_clips;
>  	}
>  
> -	clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL);
> +	clips = kcalloc(num_clips, sizeof(*clips), GFP_KERNEL);
>  	if (clips == NULL) {
>  		DRM_ERROR("Failed to allocate clip rect list.\n");
>  		ret = -ENOMEM;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/