linux-kernel - Re: [PATCH 09/11] slab, lockdep: Fix silly bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1112051503400.8257@tux.localdomain>
Date:	Mon, 5 Dec 2011 15:04:43 +0200 (EET)
From:	Pekka Enberg <penberg@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
cc:	linux-kernel@...r.kernel.org,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Carsten Emde <C.Emde@...dl.org>,
	John Kacur <jkacur@...hat.com>, stable@...nel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Hans Schillstrom <hans@...illstrom.com>,
	Christoph Lameter <cl@...two.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Matt Mackall <mpm@...enic.com>,
	Sitsofe Wheeler <sitsofe@...oo.com>, linux-mm@...ck.org,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH 09/11] slab, lockdep: Fix silly bug

On Sun, 4 Dec 2011, Steven Rostedt wrote:
> --00GvhwF7k39YY
> Content-Type: text/plain; charset="UTF-8"
> Content-Transfer-Encoding: quoted-printable
>
> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
>
> Commit 30765b92 ("slab, lockdep: Annotate the locks before using
> them") moves the init_lock_keys() call from after g_cpucache_up =3D
> FULL, to before it. And overlooks the fact that init_node_lock_keys()
> tests for it and ignores everything !FULL.
>
> Introduce a LATE stage and change the lockdep test to be <LATE.
>
> Cc: stable@...nel.org
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Hans Schillstrom <hans@...illstrom.com>
> Cc: Christoph Lameter <cl@...two.org>
> Cc: Pekka Enberg <penberg@...helsinki.fi>
> Cc: Matt Mackall <mpm@...enic.com>
> Cc: Sitsofe Wheeler <sitsofe@...oo.com>
> Cc: linux-mm@...ck.org
> Cc: David Rientjes <rientjes@...gle.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Link: http://lkml.kernel.org/n/tip-gadqbdfxorhia1w5ewmoiodd@git.kernel.org
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

Your emails seem to be damaged in interesting ways.

I assume the patch is going through the lockdep tree? If so, please make 
sure you include Christoph's ACK in the changelog.

 			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/