linux-kernel - [tip:x86/asm] x86, efi: Convert efi_phys_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-e9a9eca517d4cd94e816538efc400257e34bc63e@git.kernel.org>
Date:	Mon, 5 Dec 2011 05:29:22 -0800
From:	tip-bot for Maurice Ma <maurice.ma@...el.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, mjg@...hat.com, hpa@...or.com,
	mingo@...hat.com, rui.zhang@...el.com, matt.fleming@...el.com,
	maurice.ma@...el.com, tglx@...utronix.de, mingo@...e.hu
Subject: [tip:x86/asm] x86, efi: Convert efi_phys_get_time() args to physical addresses

Commit-ID:  e9a9eca517d4cd94e816538efc400257e34bc63e
Gitweb:     http://git.kernel.org/tip/e9a9eca517d4cd94e816538efc400257e34bc63e
Author:     Maurice Ma <maurice.ma@...el.com>
AuthorDate: Tue, 11 Oct 2011 11:52:13 +0100
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Mon, 5 Dec 2011 12:45:14 +0100

x86, efi: Convert efi_phys_get_time() args to physical addresses

Because callers of efi_phys_get_time() pass virtual stack
addresses as arguments, we need to find their corresponding
physical addresses and when calling GetTime() in physical mode.

Without this patch the following line is printed on boot,

	"Oops: efitime: can't read time!"

Signed-off-by: Maurice Ma <maurice.ma@...el.com>
Signed-off-by: Matt Fleming <matt.fleming@...el.com>
Cc: Zhang Rui <rui.zhang@...el.com>
Cc: Matthew Garrett <mjg@...hat.com>
Link: http://lkml.kernel.org/r/1318330333-4617-1-git-send-email-matt@console-pimps.org
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/platform/efi/efi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 37718f0..d2376eb 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -238,7 +238,8 @@ static efi_status_t __init phys_efi_get_time(efi_time_t *tm,
 
 	spin_lock_irqsave(&rtc_lock, flags);
 	efi_call_phys_prelog();
-	status = efi_call_phys2(efi_phys.get_time, tm, tc);
+	status = efi_call_phys2(efi_phys.get_time, virt_to_phys(tm),
+				virt_to_phys(tc));
 	efi_call_phys_epilog();
 	spin_unlock_irqrestore(&rtc_lock, flags);
 	return status;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/