linux-kernel - Re: [PATCH 01/11] MFD: DA9052/53 MFD core module v8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111205152715.GT11150@opensource.wolfsonmicro.com>
Date:	Mon, 5 Dec 2011 15:27:15 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	ashishj3 <ashish.jangam@...tcummins.com>
Cc:	sameo@...nedhand.com, linux-kernel@...r.kernel.org,
	Dajun <dajun.chen@...semi.com>, linaro-dev@...ts.linaro.org,
	arnd@...db.de, eric.miao@...aro.org, sameo@...ux.intel.com
Subject: Re: [PATCH 01/11] MFD: DA9052/53 MFD core module v8

On Mon, Dec 05, 2011 at 12:16:24PM +0530, ashishj3 wrote:

> --- a/drivers/base/regmap/regmap-irq.c
> +++ b/drivers/base/regmap/regmap-irq.c
> @@ -164,7 +164,6 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
>   * irq:       The IRQ the device uses to signal interrupts
>   * irq_flags: The IRQF_ flags to use for the primary interrupt.
>   * chip:      Configuration for the interrupt controller.
> - * data:      Runtime data structure for the controller, allocated on success

Uh, that's not good...

> -	irq_base = irq_alloc_descs(irq_base, 0, chip->num_irqs, 0);
> -	if (irq_base < 0) {
> +	*irq_base = irq_alloc_descs(*irq_base, 0, chip->num_irqs, 0);
> +	if (*irq_base < 0) {

This isn't adding an accessory, this is passing irq_base by reference.
Seems like a lot of pointers, really.  I'll send a patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/