linux-kernel - Re: [PATCH] dmaengine/ste_dma40: allow fixed physical channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1323057007.30390.58.camel@vkoul-udesk3>
Date:	Mon, 05 Dec 2011 09:20:07 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Narayanan G <narayanan.gopalakrishnan@...ricsson.com>
Cc:	linux-kernel@...r.kernel.org, linus.walleij@...ricsson.com,
	Rabin Vincent <rabin.vincent@...ricsson.com>
Subject: Re: [PATCH] dmaengine/ste_dma40: allow fixed physical channel

On Wed, 2011-11-30 at 19:20 +0530, Narayanan G wrote:
> Allow logical channels to specify the physical channel they want to use.
> This is needed to avoid two peripherals operating on the same physical
> channel during some special use-cases. (like mmc and usb during a
> usb mass storage case).
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@...ricsson.com>
> Signed-off-by: Narayanan G <narayanan.gopalakrishnan@...ricsson.com>
Applied thanks.

There are some serious format issues with this driver.
Things like this are absolutely crazy, the fact that you are too deeply
nested itslf is a problem
@@ -1676,7 +1682,8 @@ static int d40_allocate_channel(struct d40_chan
*d40c)
>  					if (d40_alloc_mask_set(&phys[i],
>  							       is_src,
>  							       0,
> -							       is_log))
> +							       is_log,
> +							       first_phy_user))
>  						goto found_phy;
>  				}
This could be made to look a lot cleaner...
Will add to my ever growing todo :D


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/