linux-kernel - Re: [PATCH] PCI: Only call pci_stop_bus_device() one time for children devices during removing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111205113803.37cc5d4c@jbarnes-desktop>
Date:	Mon, 5 Dec 2011 11:38:03 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai.lu@...cle.com>
Cc:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] PCI: Only call pci_stop_bus_device() one time for
 children devices during removing

On Tue, 22 Nov 2011 21:06:53 -0800
Yinghai Lu <yinghai.lu@...cle.com> wrote:

> 
> During debugging pcie hotplug with SRIOV with pcie switch, found
> pci_stop_bus_device() are called several times for some children devices.
> 
> Current pci_remove_bus_device() will call pci_stop_bus_device() at first.
> and then use remove_behind_bridge() to call pci_stop_bus_device() for children
> devices. But pci_stop_bus_device() already include depth first to stop children.
> So We can remove unnecessary calling in pci_remove_behind_bridge() for children.
> 
> The patch change original pci_remove_bus_device() to __pci_remove_bus_device(), and
> it only do remove work, and new pci_remove_bus_device will call
> pci_stop_bus_device() one time, and then call __pci_remove_bus_device().
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>

applied to linux-next, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)