linux-kernel - RE: [PATCH 1/1] driver core: disable device's runtime pm during shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35AB98346D25394A9354ED89C4D76587228F32@039-SN1MPN1-002.039d.mgd.msft.net>
Date:	Mon, 5 Dec 2011 05:53:27 +0000
From:	Chen Peter-B29397 <B29397@...escale.com>
To:	NeilBrown <neilb@...e.de>, Ming Lei <tom.leiming@...il.com>
CC:	"Rafael J. Wysocki" <rjw@...k.pl>, Greg KH <greg@...ah.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"hzpeterchen@...il.com" <hzpeterchen@...il.com>,
	Igor Grinberg <grinberg@...pulab.co.il>
Subject: RE: [PATCH 1/1] driver core: disable device's runtime pm during
 shutdown


 
> > > So it is asleep when the new pm_runtime_disable() call is made, so it
> stays
> > > asleep, omap_i2c_xfer cannot wake it, the transfer doesn't happen and
> the
> > > system doesn't get powered off.
> > >
> > > So here is a device that should *not* have pm disabled at shutdown.
> > >
> > > So I feel this fix is a little too heavy-handed.
> >
> > Maybe the device's runtime PM should not be disabled if
> > there is no ->shutdown defined in its driver, how about the blew?
> 
> Thanks, but that won't actually help.
> 
> dev->bus->shutdown is i2c_device_shutdown so there is a shutdown method.
> However i2c_device_shutdown just finds the driver can calls
> driver->shutdown(), and that is the 'shutdown' that is NULL.
> 
Then, i2c should be registered before than twl4030 as a platform device, since
twl4030 is an i2c device. Just let i2c shut down later than twl4030's. 

> Thanks,
> NeilBrown
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/