linux-kernel - Re: [PATCH 1/2] staging: vt6656: aes_ccmp, baseband, bssdb, card: Change BOOL to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111206061018.GD3374@mwanda>
Date:	Tue, 6 Dec 2011 09:10:18 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Marcos Paulo de Souza <marcos.mage@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 1/2] staging: vt6656: aes_ccmp, baseband, bssdb, card:
 Change BOOL to int

On Mon, Dec 05, 2011 at 10:41:54PM -0200, Marcos Paulo de Souza wrote:
> On Mon, 5 Dec 2011, Dan Carpenter wrote:
> >On Sun, Dec 04, 2011 at 11:12:46PM -0200, Marcos Paulo de Souza wrote:
> >>This patch change all references of BOOL to int. As asked by the TODO
> >>file of the driver, we need to remove the ttype.h, and this file do a
> >>typedef of int to BOOL. We don't need this.
> 
> Dan, I'm trying to remove this chunk of code:
> 
> drivers/staging/vt6656/ttype.h:
> 
> typedef int BOOL;
> 
> Are we talinkg about the same BOOL type?
> 

Yes.

> >
> >Why not use bool?  Especially inside structs bool takes up less
> >space than an int.  Also static analysis tools care about the type.
> 
> This typedef is about a int type.

Yes.  I know that.  But these things are used like bool not like int
so bool is the correct thing.

Bool is a different type from int, so you'll have to verify that
changing it doesn't break anything.  It's a more difficult change
but it's the right thing to do.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)