linux-kernel - Re: [patch v3 3/6] sched, nohz: sched group, domain aware nohz idle load balancing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111206063736.GA18040@linux.vnet.ibm.com>
Date:	Tue, 6 Dec 2011 12:07:36 +0530
From:	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	Venki Pallipadi <venki@...gle.com>,
	Mike Galbraith <efault@....de>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Tim Chen <tim.c.chen@...ux.jf.intel.com>, alex.shi@...el.com
Subject: Re: [patch v3 3/6] sched, nohz: sched group, domain aware nohz idle
 load balancing

* Suresh Siddha <suresh.b.siddha@...el.com> [2011-12-01 17:07:34]:

> @@ -5090,7 +5019,7 @@ static void nohz_idle_balance(int this_c
>  		goto end;
> 
>  	for_each_cpu(balance_cpu, nohz.idle_cpus_mask) {
> -		if (balance_cpu == this_cpu)
> +		if (balance_cpu == this_cpu || !idle_cpu(this_cpu))
>  			continue;

Hmm ..did you mean to use '!idle_cpu(balance_cpu)' there? If the intent
was on checking this_cpu becoming busy, then we'd rather do a break on
that condition rather than continuing with the loop?

- vatsa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/