linux-kernel - [PATCH] intel_idle: delete meaningless local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <625BA99ED14B2D499DC4E29D8138F1506C27997A12@shsmsx502.ccr.corp.intel.com>
Date:	Tue, 6 Dec 2011 14:40:29 +0800
From:	"Zhang, MingmingX" <mingmingx.zhang@...el.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"yanmin_zhang@...ux.intel.com" <yanmin_zhang@...ux.intel.com>
Subject: [PATCH]  intel_idle: delete meaningless local_irq_disable() call 

Delete meaningless local_irq_disable() call in intel_idle.c.
                                      
intel_idle.c is a bit misleading in a sense that local_irq_disable in
it actually does nothing. Real irq disable happens earlier in process_32.c:cpu_idle.

Signed-off-by: Mingming Zhang <mingmingx.zhang@...el.com>
---
drivers/idle/intel_idle.c |    2 --
1 file changed, 2 deletions(-)

--- linux-3.1.4/drivers/idle/intel_idle.c     2011-11-29 07:48:14.000000000 +0900
+++ linux/drivers/idle/intel_idle.c   2011-12-06 13:40:52.161155012 +0900
@@ -223,8 +223,6 @@ static int intel_idle(struct cpuidle_dev

        cstate = (((eax) >> MWAIT_SUBSTATE_SIZE) & MWAIT_CSTATE_MASK) + 1;

-        local_irq_disable();
-
       /*
        * leave_mm() to avoid costly and often unnecessary wakeups
        * for flushing the user TLB's associated with the active mm.

Thanks
Mingming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/