linux-kernel - Re: [PATCH 2/5] power: sbs-battery: rename internals to new name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323134410.24760.1.camel@rklein-linux2>
Date:	Mon, 05 Dec 2011 17:20:10 -0800
From:	Rhyland Klein <rklein@...dia.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH 2/5] power: sbs-battery: rename internals to new name

On Mon, 2011-12-05 at 17:20 -0800, Anton Vorontsov wrote:
> On Mon, Dec 05, 2011 at 03:58:04PM -0800, Rhyland Klein wrote:
> [...]
> > -static const struct i2c_device_id bq20z75_id[] = {
> > -	{ "bq20z75", 0 },
> > +static const struct i2c_device_id sbs_id[] = {
> > +	{ "sbs-battery", 0 },
> 
> You have to leave "bq20z75" here as is, and add "sbs-battery" as an
> additional device id.
> 
> The reason is that older device trees might already have compatible
> = "bq20z75", without specifying "sbs-battery".
> 
> Thanks!
> 

Good thought! I had thought about that at some point but apparently not
when actually working on the patch. Will do in v2.

-rhyland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/