linux-kernel - Re: [PATCH] ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hhb1dnauk.wl%tiwai@suse.de>
Date:	Tue, 06 Dec 2011 13:28:03 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	perex@...ex.cz, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array

At Tue, 29 Nov 2011 22:08:00 +0100,
Thomas Meyer wrote:
> 
> The advantage of kcalloc is, that will prevent integer overflows which could
> result from the multiplication of number of elements and size and it is also
> a bit nicer to read.
> 
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>

Thanks, applied both this and asihpi patches.


Takashi

> ---
> 
> diff -u -p a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c
> --- a/sound/pci/ctxfi/ctsrc.c 2011-11-13 11:08:15.090921741 +0100
> +++ b/sound/pci/ctxfi/ctsrc.c 2011-11-28 20:14:46.651112893 +0100
> @@ -437,7 +437,7 @@ get_src_rsc(struct src_mgr *mgr, const s
>  
>  	/* Allocate mem for master src resource */
>  	if (MEMRD == desc->mode)
> -		src = kzalloc(sizeof(*src)*desc->multi, GFP_KERNEL);
> +		src = kcalloc(desc->multi, sizeof(*src), GFP_KERNEL);
>  	else
>  		src = kzalloc(sizeof(*src), GFP_KERNEL);
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/