linux-kernel - Re: [PATCH 2/7] perf: add ability to record event period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111206140203.GC10709@infradead.org>
Date:	Tue, 6 Dec 2011 12:02:03 -0200
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Andrew Vagin <avagin@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	paulus@...ba.org, mingo@...e.hu, asharma@...com, devel@...nvz.org,
	dsahern@...il.com, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 2/7] perf: add ability to record event period

Em Mon, Nov 28, 2011 at 12:03:30PM +0300, Andrew Vagin escreveu:
> Signed-off-by: Andrew Vagin <avagin@...nvz.org>
> ---
>  tools/perf/builtin-record.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

This patch doesn't apply in current tip/perf/core as this logic was
moved to perf_evsel/perf_evlist, so that it can be used by other tools.

Please add the 'period' variable to struct perf_record_opts and the
sample_type or'ing to perf_evsel__config().

I suggest you use https://github.com/acmel/linux/commits/perf/core for
that.

- Arnaldo
 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 6ab58cc..e3b7fc4 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -62,6 +62,7 @@ static bool			no_samples			=  false;
>  static bool			sample_address			=  false;
>  static bool			sample_time			=  false;
>  static bool			no_buildid			=  false;
> +static bool			period				=  false;
>  static bool			no_buildid_cache		=  false;
>  static struct perf_evlist	*evsel_list;
>  
> @@ -185,6 +186,9 @@ static void config_attr(struct perf_evsel *evsel, struct perf_evlist *evlist)
>  	if (evlist->nr_entries > 1)
>  		attr->sample_type |= PERF_SAMPLE_ID;
>  
> +	if (period)
> +		attr->sample_type |= PERF_SAMPLE_PERIOD;
> +
>  	/*
>  	 * We default some events to a 1 default interval. But keep
>  	 * it a weak assumption overridable by the user.
> @@ -803,6 +807,7 @@ const struct option record_options[] = {
>  	OPT_BOOLEAN('d', "data", &sample_address,
>  		    "Sample addresses"),
>  	OPT_BOOLEAN('T', "timestamp", &sample_time, "Sample timestamps"),
> +	OPT_BOOLEAN('P', "period", &period, "Sample period"),
>  	OPT_BOOLEAN('n', "no-samples", &no_samples,
>  		    "don't sample"),
>  	OPT_BOOLEAN('N', "no-buildid-cache", &no_buildid_cache,
> -- 
> 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/