linux-kernel - Re: [PATCH V2 net] ipv4:correct description for tcp_max_syn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111206140709.GA29082@hmsreliant.think-freely.org>
Date:	Tue, 6 Dec 2011 09:07:09 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Weiping Pan <panweiping3@...il.com>
Cc:	shanwei88@...il.com, Randy Dunlap <rdunlap@...otime.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Shan Wei <shanwei@...fujitsu.com>,
	Max Matveev <makc@...hat.com>,
	"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>
Subject: Re: [PATCH V2 net] ipv4:correct description for tcp_max_syn_backlog

On Tue, Dec 06, 2011 at 03:39:41PM +0800, Weiping Pan wrote:
> Since commit c5ed63d66f24(tcp: fix three tcp sysctls tuning),
> sysctl_max_syn_backlog is determined by tcp_hashinfo->ehash_mask,
> and the minimal value is 128, and it will increase in proportion to the
> memory of machine.
> The original description for tcp_max_syn_backlog and sysctl_max_syn_backlog
> are out of date.
> 
> Changelog:
> V2: update description for sysctl_max_syn_backlog
> 
> Signed-off-by: Weiping Pan <panweiping3@...il.com>
> ---
>  Documentation/networking/ip-sysctl.txt |   10 +++++-----
>  net/core/request_sock.c                |    7 ++++---
>  2 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index f049a1c..589f2da 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -282,11 +282,11 @@ tcp_max_ssthresh - INTEGER
>  	Default: 0 (off)
>  
>  tcp_max_syn_backlog - INTEGER
> -	Maximal number of remembered connection requests, which are
> -	still did not receive an acknowledgment from connecting client.
> -	Default value is 1024 for systems with more than 128Mb of memory,
> -	and 128 for low memory machines. If server suffers of overload,
> -	try to increase this number.
> +	Maximal number of remembered connection requests, which have not
> +	received an acknowledgment from connecting client.
> +	The minimal value is 128 for low memory machines, and it will
> +	increase in proportion to the memory of machine.
> +	If server suffers from overload, try increasing this number.
>  
>  tcp_max_tw_buckets - INTEGER
>  	Maximal number of timewait sockets held by system simultaneously.
> diff --git a/net/core/request_sock.c b/net/core/request_sock.c
> index 182236b..9b570a6 100644
> --- a/net/core/request_sock.c
> +++ b/net/core/request_sock.c
> @@ -26,10 +26,11 @@
>   * but then some measure against one socket starving all other sockets
>   * would be needed.
>   *
> - * It was 128 by default. Experiments with real servers show, that
> + * The minimum value of it is 128. Experiments with real servers show that
>   * it is absolutely not enough even at 100conn/sec. 256 cures most
> - * of problems. This value is adjusted to 128 for very small machines
> - * (<=32Mb of memory) and to 1024 on normal or better ones (>=256Mb).
> + * of problems.
> + * This value is adjusted to 128 for low memory machines,
> + * and it will increase in proportion to the memory of machine.
>   * Note : Dont forget somaxconn that may limit backlog too.
>   */
>  int sysctl_max_syn_backlog = 256;
> -- 
> 1.7.4.4
> 
> 
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/