linux-kernel - Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111206181715.GG3366@decadent.org.uk>
Date:	Tue, 6 Dec 2011 18:17:15 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on
 error

On Tue, Dec 06, 2011 at 06:59:19PM +0100, Ingo Molnar wrote:
> 
> * Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> 
> > On Tue, 06 Dec 2011 18:48:51 +0100
> > Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> > 
> > > On Tue, 2011-12-06 at 15:34 +0000, Ben Hutchings wrote:
> 
> > > > If you disagree with a patch, do not silently drop parts 
> > > > of it.  I demand that you remove my 'Signed-off-by' as 
> > > > this is not the change I submitted.
> > > 
> > > The easy solution is that I never take patches from you 
> > > again, ever. Consider that done. I'll let Ingo see if he can 
> > > remove your SOB.
> > 
> > In which case you are presumably ceasing to be a maintainer 
> > for that code ? Your statement above appears to be 
> > inconsistent with the rôle of a maintainer.
> 
> What Peter did was rather sensible: he split a patch that did 
> two things into two and applied one standalone, uncontroversial 
> half of it and kept the part of the part of the changelog that 
> related to that change.
[...]

I can accept that if the change from my submission is commented
in the commit message.  (I sometimes do that with other people's
patches.)  But this was modified without comment.

Giving credit for authorship is important, but it is also
important not to say someone is the sole author of something
when they aren't and haven't approved the subsequent changes
(cf. Alan Smithee).
 
Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/