linux-kernel - Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111206182035.GA12094@elte.hu>
Date:	Tue, 6 Dec 2011 19:20:35 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Nick Bowler <nbowler@...iptictech.com>
Cc:	Ben Hutchings <ben@...adent.org.uk>, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on
 error

* Nick Bowler <nbowler@...iptictech.com> wrote:

> > Your original patch did two things. Peter did the sensible 
> > thing: he split out the print_kernel_ident() changes from 
> > your patch which stand on their own and kept your authorship 
> > in place - that is what the above patch does.
> 
> In which case, the changelog should have been amended to state 
> that it's a modification of Ben's original submission.

Which is what i said in my reply to Alan:

 | What Peter probably could have done is to add one more line
 | before his SOB:
 |
 |   [ split out the patch from the original submission ]
 |   Signed-off-by: Peter Zijlstra <peterz@...radead.org>
 |
 | Otherwise Ben Hutchings's objection here makes little sense.

No line of code was added by Peter - it's all Ben's changes.

Note that the commit in question:

  fbdc4b9a6c29: lockdep, rtmutex, bug: Show taint flags on error

is actually a good one and i think even Ben actually thinks 
those changes are good. Nothing was added - Ben only wants 
*more* to be done in a single patch and is being silly about the 
SOB and is asking it to be removed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/