linux-kernel - Re: [PATCH] ARM: futex: fix clobbering oldval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Dec 2011 19:11:09 +0000
From:	Will Deacon <will.deacon@....com>
To:	Jon Masters <jcm@...hat.com>
Cc:	mhban <mhban@...sung.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	DavidHowells <dhowells@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Michel Lespinasse <walken@...gle.com>,
	Russell King <linux@....linux.org.uk>,
	Chris Metcalf <cmetcalf@...era.com>
Subject: Re: [PATCH] ARM: futex: fix clobbering oldval

Hi Jon,

On Tue, Dec 06, 2011 at 06:58:34PM +0000, Jon Masters wrote:
> On Thu, 2011-09-22 at 18:26 +0100, Will Deacon wrote:
> > Hi,
> > 
> > On Thu, Sep 22, 2011 at 03:53:35AM +0100, mhban wrote:
> > > This patch fixes clobbering oldval bug. oldval should be preserved for next
> > > compare operation.
> > > 
> > > Change-Id: I2a63bc1bdb8de330eb9e1ac02d7da1f77e6e8c3c
> > > Signed-off-by: Minho Ban <mhban@...sung.com>
> > 
> > It would have been nice to have been CC'd on this...
> > 
> > I ran LTP tests on this, so I'm surprised that this was broken (the tests
> > passed). Well spotted anyway!
> 
> This appears to be the cause of our "stuck builder" problem in Fedora
> building certain large packages, such as OpenJDK. Some of our guys are
> still monitoring the situation in case there's a secondary issue.
> 
> Was there ever any additional followup on this topic?

Yup, check commit df77abca ("ARM: 7099/1: futex: preserve oldval in SMP
__futex_atomic_op"). It should be in stable for all affected kernels too.

Cheers,

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/