linux-kernel - Re: [tip:core/locking] lockdep, kmemcheck: Annotate ->lock in lockdep_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Dec 2011 11:56:51 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, vegard.nossum@...il.com,
	sergey.senozhatsky@...il.com, bp@...en8.de, tj@...nel.org,
	yong.zhang0@...il.com, tglx@...utronix.de, mingo@...e.hu
cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/locking] lockdep, kmemcheck: Annotate ->lock in
 lockdep_init_map()

On Tue, 6 Dec 2011, tip-bot for Yong Zhang wrote:

> Commit-ID:  d3d03d4fc5b1bec3a579112de170a9676e9d97cb
> Gitweb:     http://git.kernel.org/tip/d3d03d4fc5b1bec3a579112de170a9676e9d97cb
> Author:     Yong Zhang <yong.zhang0@...il.com>
> AuthorDate: Wed, 9 Nov 2011 16:04:51 +0800
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Tue, 6 Dec 2011 08:16:51 +0100
> 
> lockdep, kmemcheck: Annotate ->lock in lockdep_init_map()
> 
> Since commit f59de89 ("lockdep: Clear whole lockdep_map on initialization"),
> lockdep_init_map() will clear all the struct. But it will break
> lock_set_class()/lock_set_subclass(). A typical race condition
> is like below:
> 
>      CPU A                                   CPU B
> lock_set_subclass(lockA);
>  lock_set_class(lockA);
>    lockdep_init_map(lockA);
>      /* lockA->name is cleared */
>      memset(lockA);
>                                      __lock_acquire(lockA);
>                                        /* lockA->class_cache[] is cleared */
>                                        register_lock_class(lockA);
>                                          look_up_lock_class(lockA);
>                                            WARN_ON_ONCE(class->name !=
>                                                      lock->name);
> 
>      lock->name = name;
> 
> So restore to what we have done before commit f59de89 but annotate
> ->lock with kmemcheck_mark_initialized() to suppress the kmemcheck
> warning reported in commit f59de89.
> 
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Reported-by: Borislav Petkov <bp@...en8.de>
> Suggested-by: Vegard Nossum <vegard.nossum@...il.com>
> Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: David Rientjes <rientjes@...gle.com>

Acked-by: David Rientjes <rientjes@...gle.com>

> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Link: http://lkml.kernel.org/r/20111109080451.GB8124@zhy
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/