linux-kernel - Re: [git pull] apparmor fix for __d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwbWUBs3Fy1hyP3CQ15rF2opvjxLR8gnSF5gERDGCGhOw@mail.gmail.com>
Date:	Tue, 6 Dec 2011 13:07:56 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	John Johansen <john.johansen@...onical.com>
Subject: Re: [git pull] apparmor fix for __d_path() misuse

On Tue, Dec 6, 2011 at 12:53 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> The trouble is, might very well stop *NOT* at the global root.  Consider
> a race with umount -l; we have no way to tell "it had been outside of
> chroot jail" from "it had walked up to the place where ->mnt_parent had
> been already reset, sorry, no idea what it was".

Sure, but you made that case return NULL already as part of the "no
bastard" case, didn't you?

That part of the patch looked fine.

It was just the extra convolutions around 'bastard' that seemed to be
over-designed, and made for just a single use that seems very
peripheral anyway.

Apart from AppArmor, afaik nobody even really cared where they ended
up, and even AppArmor really didn't want to know - it just had this
totally crazy special case about "/sys".

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/