linux-kernel - UV serial regression since 2.6.36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EDE988B.6010501@suse.cz>
Date:	Tue, 06 Dec 2011 23:34:51 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	LKML <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arnd Bergmann <arnd@...db.de>, Greg KH <gregkh@...e.de>,
	Jiri Slaby <jirislaby@...il.com>
Subject: UV serial regression since 2.6.36

Hi,

In short, the issue causes serial port traffic to stop after some time
on UV machines. Only when serial is used as a console. It worked
perfectly with 2.6.32. It's a standard 16550 on 0x3f8 (well, it's
emulated to be at that port). Also in the PNP subsys.

To reproduce that 'debug' kernel parameter must not be used.

The root cause seems to be that the serial "chip" there has problems
with interrupts. It generates some but doesn't indicate it's the source
or somebody clears it (NOINT is set). And when it is supposed to
generate one (on THRE), it does not. So there are bytes in the TX buffer
which are never sent. Until the port is kicked e.g. by "echo h >
/proc/sysrq-trigger".

The unhandled interrupts were always an issue, but somehow hidden. It
became a real problem with patches post 2.6.32.

I bisected it to these two commits _together_:

commit 3f582b8c11014e4ce310d9839fb335164195333f
Author: Arnd Bergmann <arnd@...db.de>
Date:   Tue Jun 29 22:31:40 2010 +0200

    serial: fix termios settings in open

AND

commit 74c2107759dc6efaa1b9127014be58a742a1e7ac
Author: Alan Cox <alan@...ux.intel.com>
Date:   Tue Jun 1 22:53:00 2010 +0200

    serial: Use block_til_ready helper

Those reverted on the top of 2.6.37 makes it work again. Those reverted
on the top of 3.0 plus mine 3 reverted which removed update_set_termios
completely makes it work again.

I didn't look closely to why those patches are causing that. Like
c_cflag copy in uart_update_termios and "tty->termios->c_cflag & CBAUD"
test in tty_port_block_til_ready don't look good to me...

<rant from a person who spent with that bug 2 weeks :( >
I had to bisect three times. First to find a patch which allows booting
on <2.6.36 kernels on that machine. Second to narrow down the interval
-- it pointed to a merge commit. The third one to find the culprit.

The third one was unsuccessful because of two commits causing the issue.
Yes, hunting this crap

Now I'm going on vacation till the end of the year so I will be seldomly
responding.
</rant>

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/