linux-kernel - Re: [tip:x86/apic] x86: Add NumaChip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EDD5D77.3030101@numascale.com>
Date:	Tue, 06 Dec 2011 01:10:31 +0100
From:	Steffen Persvold <sp@...ascale.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	jbarnes@...tuousgeek.org, tglx@...utronix.de,
	daniel@...ascale-asia.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/apic] x86: Add NumaChip support

On 12/5/2011 21:31, Ingo Molnar wrote:
[]
> There's a new build failure caused by this commit:

It's this commit actually :

Commit-ID:  64be4c1c2428e148de6081af235e2418e6a66dda
Gitweb:     http://git.kernel.org/tip/64be4c1c2428e148de6081af235e2418e6a66dda
Author:     Daniel J Blueman <daniel@...ascale-asia.com>
AuthorDate: Mon, 5 Dec 2011 16:20:37 +0800
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Mon, 5 Dec 2011 17:17:21 +0100

x86: Add x86_init platform override to fix up NUMA core numbering

> 
>   arch/x86/kernel/cpu/common.c:1149:2: error: ‘struct cpuinfo_x86’ has no member named ‘phys_proc_id’
> 
> Note that the config is a !SMP one - that's probably the key
> detail.

Yes, phys_proc_id in struct cpuinfo_x86 is covered within "ifdef CONFIG_SMP".

> 
> Please send a delta fix that resolves this bug. You can find the
> current lineup in:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> 

Will do, should be fairly simple. Something in the lines of the attached should work (tested).

Note: I used "ifdef CONFIG_NUMA" simply because it doesn't make sense in a non-numa configuration even with SMP enabled. Besides, the only place where it is called right now is in kernel/cpu/amd.c:srat_detect_node() within the "CONFIG_NUMA" protected part.

Cheers,
-- 
Steffen Persvold, Chief Architect NumaChip
Numascale AS - www.numascale.com
Tel: +47 92 49 25 54 Skype: spersvold

View attachment "0002-x86_init-core-numbering-delta.patch" of type "text/x-patch" (453 bytes)