| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 Dec 2011 17:18:26 +0900 From: Kenji Kaneshige <kaneshige.kenji@...fujitsu.com> To: Yinghai Lu <yinghai@...nel.org> CC: Linus Torvalds <torvalds@...ux-foundation.org>, Jesse Barnes <jbarnes@...tuousgeek.org>, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [git pull] PCI fixes + /* Configuration request Retry Status */ + if (l == 0xffff0001) + goto wait; I think this works only when CRS Software Visibility is enabled, isn't it? Currently there is no code to enable CRS Software Visibility. And there can be root ports that doesn't support CRS Software Visibility. We need consideration about this. + mdelay(100); + delay -= 100; + if (delay > 0) + goto again; We must use msleep() instead of mdelay(). Regards, Kenji Kaneshige (2011/12/07 7:36), Yinghai Lu wrote: > On Tue, Dec 6, 2011 at 8:14 AM, Linus Torvalds > <torvalds@...ux-foundation.org> wrote: >> Please try to make something like that work. Instead of always waiting >> for one second, wait for up to one second only for failure cases. Any >> possibility of that? > > i had another version that was not send out. that worked on my test setups too. > it will try to read pci conf several times in 1s. > > please check refreshed version against your tree. > > Thanks > > Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists