linux-kernel - Re: [PATCH 10/10] perf tools: Use for_each_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111207083050.GP15738@erda.amd.com>
Date:	Wed, 7 Dec 2011 09:30:50 +0100
From:	Robert Richter <robert.richter@....com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
CC:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/10] perf tools: Use for_each_set_bit() to iterate over
 feature flags

On 06.12.11 11:40:54, Arnaldo Carvalho de Melo wrote:
> What would be really great would be to just use the kernel one like in
> 
> tools/perf/util/include/linux/list.h
> tools/perf/util/include/linux/rbtree.h
> 
> But that was source of contention in the past when changes in the kernel
> side broke the tools, i.e. the headers were not explicitely designed for
> such sharing.

Yeah, that didn't work out, esp. because of architectural includes and
optimizations. For most cases we don't need that level of optimization
since code is not used in the fast path.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/