linux-kernel - Re: linux-next: manual merge of the tip tree with the cputime tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 7 Dec 2011 12:59:37 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Glauber Costa <glommer@...allels.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	<linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: manual merge of the tip tree with the cputime tree

On Wed, 7 Dec 2011 09:35:09 -0200
Glauber Costa <glommer@...allels.com> wrote:

> On 12/07/2011 02:09 AM, Stephen Rothwell wrote:
> > + 	index = (TASK_NICE(p)>  0) ? CPUTIME_NICE : CPUTIME_USER;
> > +
> >    	/* Add user time to cpustat. */
> > - 	if (TASK_NICE(p)>  0)
> > - 		cpustat->nice += (__force cputime64_t) cputime;
> > - 	else
> > - 		cpustat->user += (__force cputime64_t) cputime;
> >   -	task_group_account_field(p, index, cputime);
> > ++	task_group_account_field(p, index, (__force cputime64_t) cputime);
> 
> 
> I doubt __force cputime64_t is necessary. After these patches, those 
> fields are all u64.

You need the __force keyword whenever a conversion between a cputime[64]_t
and a plain scalar type is done. The cputime[64]_t types are defined with
__nocast so that sparse can find bugs in the usage of cputime.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/