linux-kernel - Re: [PATCH 21/25] kernel/module: replace DEBUGP with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zkf5i3yv.fsf@rustcorp.com.au>
Date:	Wed, 07 Dec 2011 11:37:52 +1030
From:	Rusty Russell <rusty@...abs.org>
To:	jim.cromie@...il.com, jbaron@...hat.com
Cc:	greg@...ah.com, joe@...ches.com, bart.vanassche@...il.com,
	linux-kernel@...r.kernel.org, Jim Cromie <jim.cromie@...il.com>
Subject: Re: [PATCH 21/25] kernel/module: replace DEBUGP with pr_debug

On Tue,  6 Dec 2011 12:11:31 -0700, jim.cromie@...il.com wrote:
> From: Jim Cromie <jim.cromie@...il.com>
> 
> Use more flexible pr_debug.  This allows:
> 
>   echo "module module +p" > /dbg/dynamic_debug/control
> 
> to turn on debug messages when needed.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>  kernel/module.c |   44 +++++++++++++++++++-------------------------
>  kernel/params.c |   14 ++++----------
>  2 files changed, 23 insertions(+), 35 deletions(-)

Split into 2 and applied.  This is a win, independent of the rest.

I reused the same commit message for the second patch,
with minor mods:

From: Jim Cromie <jim.cromie@...il.com>
Subject: kernel/params: replace DEBUGP with pr_debug
Date: Tue, 6 Dec 2011 12:11:31 -0700

Use more flexible pr_debug.  This allows:

  echo "module params +p" > /dbg/dynamic_debug/control

to turn on debug messages when needed.

Signed-off-by: Jim Cromie <jim.cromie@...il.com>
Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
---
 kernel/params.c |   14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/