linux-kernel - Re: [PATCH 5/5 V5] Add check for suspended vm in softlockup detector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EDF7A72.5020703@redhat.com>
Date:	Wed, 07 Dec 2011 16:38:42 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Eric B Munson <emunson@...bm.net>
CC:	mingo@...hat.com, hpa@...or.com, arnd@...db.de,
	ryanh@...ux.vnet.ibm.com, aliguori@...ibm.com, mtosatti@...hat.com,
	jeremy.fitzhardinge@...rix.com, levinsasha928@...il.com,
	Jan Kiszka <jan.kiszka@...mens.com>, kvm@...r.kernel.org,
	linux-arch@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5 V5] Add check for suspended vm in softlockup detector

On 12/05/2011 10:19 PM, Eric B Munson wrote:
> A suspended VM can cause spurious soft lockup warnings.  To avoid these, the
> watchdog now checks if the kernel knows it was stopped by the host and skips
> the warning if so.  When the watchdog is reset successfully, clear the guest
> paused flag.
>
>  int watchdog_enabled = 1;
> @@ -280,6 +281,9 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
>  			__this_cpu_write(softlockup_touch_sync, false);
>  			sched_clock_tick();
>  		}
> +
> +		/* Clear the guest paused flag on watchdog reset */
> +		kvm_check_and_clear_guest_paused(smp_processor_id());
>  		__touch_watchdog();
>  		return HRTIMER_RESTART;
>  	}

Won't build if !CONFIG_KVMCLOCK


-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/