linux-kernel - Re: [git pull] apparmor fix for __d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzz7M=SoPwzACxQK+mc8BZRHy03z-T-Q_4mmcCQ0YhtJg@mail.gmail.com>
Date:	Tue, 6 Dec 2011 18:02:22 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	John Johansen <john.johansen@...onical.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] apparmor fix for __d_path() misuse

On Tue, Dec 6, 2011 at 5:23 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> Damnit, it may very well be NOT ANY KIND OF ROOT AT ALL.  Which is what
> I'd been trying to tell you all along.  You can race with umount -l.
> In that case that thing might have been *INSIDE* your chroot jail.
> Anywhere in it.

AND NOBODY CARES.

That's the deeper point here. IT DOES NOT MATTER.

Why do you try to convince people that it does. Nobody uses the
information that you claim is so magically important.

You are the only one who seems to think that it matters. No code
agrees with you except for the clearly broken AppArmor code that
everybody agrees should just go the f*ck away.

> See what I'm talking about?  I'm fine with giving the pathname to global
> root.  It's doing that to *random* just-unmounted vfsmount that is not
> a good thing.

It *never* matters. The pathname should never be used at all.

We want to *see* what the pathname is, but no code should ever use it.

The *only* valid use for the broken pathname is for a "show user debug
information". That's all I've ever claimed. The "where it was mounted
- or *if* it was mounted" part is pointless.

Why do you keep on harping on this totally useless issue? Seriously?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/