linux-kernel - Re: [PATCH 0/3 v2] usb/hid-core: drain URB queue when going to suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGS+omBvSWz4vBsMDkwk3oge_+k64tqSkrHyF5-C5_LZte_hDw@mail.gmail.com>
Date:	Wed, 7 Dec 2011 10:42:55 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	jkosina@...e.cz, oneukum@...e.de, bleung@...omium.org
Cc:	stern@...land.harvard.edu, olofj@...omium.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, Daniel Kurtz <djkurtz@...omium.org>
Subject: Re: [PATCH 0/3 v2] usb/hid-core: drain URB queue when going to suspend

On Thu, Nov 17, 2011 at 7:23 PM, Daniel Kurtz <djkurtz@...omium.org> wrote:
>
> In some situations, trying to suspend a laptop with an attached USB keyboard
> would fail if both NumLock and CapsLock LEDs were lit.
> This was due to a race condition between asynchronously submitted
> LED-manipulating CTRL URBs and the suspend process.
>
> This is a different solution to the same problem highlighted here:
> https://lkml.org/lkml/2011/9/2/391
>
> These patches are against Jiri's hid/for-next branch.
>
> Daniel Kurtz (3):
>  HID: usbhid: remove LED_ON
>  HID: usbhid: hid-core: submit queued urbs before suspend
>  HID: usbhid: defer LED setting to a workqueue
>
> Differences since v1:
>  * Rebase on hid/for-next
>  * Solve race with usbhid_stop() [reported by Oliver Neukum]
>

Hi Jiri,

Any chance you can take a look at this patch set?

-Dan

>  drivers/hid/hid-input.c       |   42 +++++++
>  drivers/hid/usbhid/hid-core.c |  241 ++++++++++++++++++++++++-----------------
>  drivers/hid/usbhid/usbhid.h   |    3 +-
>  include/linux/hid.h           |    2 +
>  4 files changed, 187 insertions(+), 101 deletions(-)
>
> --
> 1.7.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/