linux-kernel - RE: [PATCH 1/3 v4] usb: tegra20-ehci: Add devicetree support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF1750B77736@HQMAIL01.nvidia.com>
Date:	Wed, 7 Dec 2011 09:08:26 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Andrew Chew <AChew@...dia.com>
CC:	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"olof@...om.net" <olof@...om.net>,
	Dan Willemsen <dwillemsen@...dia.com>,
	Rhyland Klein <rklein@...dia.com>,
	Venkat Moganty <vmoganty@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/3 v4] usb: tegra20-ehci: Add devicetree support.

Jean-Christophe PLAGNIOL-VILLARD wrote at Tuesday, December 06, 2011 8:42 PM:
> On 14:17 Thu 21 Jul     , achew@...dia.com wrote:
> > From: Andrew Chew <achew@...dia.com>
> >
> > Add code to try to get platform data information (register base, irq,
> > modes, various tuning parameters) from device tree, if not present in board
> > files.
...
> > +static u64 tegra_ehci_dmamask = DMA_BIT_MASK(TEGRA_USB_DMA_ALIGN);
> I really does not like this
> as the dmamask is supposed to be device specific
> 
> before we put it in the soc codewhich alow to have it generic
> 
> this need to be manage a DT level
> 	dmamask = <32>
> 
> or
> 	dmamask = <0xffffffff>

Jean-Christophe,

The patch you're replying to is very old; Olof has posted (and applied)
some basic USB bindings much more recently than the above.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/