linux-kernel - Re: [PATCH -resend 1/1] SPI: disable CONFIG_SPI_FSL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111207203348.GB2526@pengutronix.de>
Date:	Wed, 7 Dec 2011 21:33:48 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	grant.likely@...retlab.ca, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com
Subject: Re: [PATCH -resend 1/1] SPI: disable CONFIG_SPI_FSL_ESPI=m build

On Wed, Dec 07, 2011 at 09:18:16PM +0100, Jiri Slaby wrote:
> When spi_fsl_espi is chosen to be built as a module, there is a build
> error because we test only CONFIG_SPI_FSL_ESPI in declaration of
> struct mpc8xxx_spi in drivers/spi/spi_fsl_lib.h. Also some called
> functions are not exported.
> 
> So we forbid CONFIG_SPI_FSL_ESPI to be tristate here.
> 
> The error looks like:
> drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_bufs':
> drivers/spi/spi_fsl_espi.c:232: error: 'struct mpc8xxx_spi' has no member named 'len'
> ...
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Acked-by: Kumar Gala <galak@...nel.crashing.org>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> ---
> Maybe Grant is back already?

I just picked it up in the for-linus branch I am preparing while Grant
is away.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)