linux-kernel - Re: [patch] x86, NMI: add to_cpumask() to silence compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111207211238.GJ1669@redhat.com>
Date:	Wed, 7 Dec 2011 16:12:38 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Ingo Molnar <mingo@...e.hu>, mingo@...hat.com, hpa@...or.com,
	linux-kernel@...r.kernel.org, andi@...stfloor.org,
	torvalds@...ux-foundation.org, peterz@...radead.org,
	robert.richter@....com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [patch] x86, NMI: add to_cpumask() to silence compile warning

On Wed, Dec 07, 2011 at 02:06:12PM +0300, Dan Carpenter wrote:
> Gcc complains if we don't cast this to a struct cpumask pointer.
> arch/x86/kernel/nmi_selftest.c:93:2:
> 	warning: passing argument 1 of ‘cpumask_empty’ from
> 	incompatible pointer type [enabled by default]
> 

Crap, another fallout found by Randy.

Cheers,
Don

---8<---
From: Don Zickus <dzickus@...hat.com>
Date: Wed, 7 Dec 2011 16:03:40 -0500
Subject: [PATCH] x86, NMI: NMI selftest depends on the local apic

The selftest doesn't work with out a local apic for now.

Reported-by: Randy Dunlap <rdunlap@...otime.net>
Signed-off-by: Don Zickus <dzickus@...hat.com>
---
 arch/x86/Kconfig.debug |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 020a4f1..d6eea6d 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -286,7 +286,7 @@ config DEBUG_STRICT_USER_COPY_CHECKS
 
 config DEBUG_NMI_SELFTEST
 	bool "NMI Selftest"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && X86_LOCAL_APIC
 	---help---
 	  Enabling this option turns on a quick NMI selftest to verify
 	  that the NMI behaves correctly.
-- 
1.7.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/