linux-kernel - Re: [PATCH v2] soc/lapis: add machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Dec 2011 13:42:45 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Mike Frysinger <vapier@...too.org>,
	Daniel Mack <zonque@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH v2] soc/lapis: add machine driver

2011/12/6 Tomoya MORINAGA <tomoya.rohm@...il.com>:
>>> >> +     ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
>>> >> +                             SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);
>>> >> +     if (ret < 0)
>>> >> +             return ret;
>>
>>> > Use the dai_fmt field in the dai_link to set this.
>>
>>> Sorry, I can't understand your saying.
>>> Let me know in more detail.
>>
>> I'm not sure what more to say...  Have you looked at that field and how
>> it is both implemented and used in other drivers, or at the commit logs
>> for relevant changes?  What do you find unclear?
>
> You said "Use the dai_fmt field in the dai_link to set this."
> However, both dai_fmt and dai_link are already implemented like below.
> static struct snd_soc_dai_link ioh_i2s_dai = {
> ...
> };
>
> static struct snd_soc_card ioh_i2s_card = {
> ...
>        .dai_link       = &ioh_i2s_dai,
> ...
> };
> So, I can't understand your saying.

Could you give me your answer ?

thanks,

tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/