linux-kernel - Re: [PATCH] lockdep, bug: Exclude TAINT_OOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8762hrit26.fsf@rustcorp.com.au>
Date:	Thu, 08 Dec 2011 15:00:25 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ben Hutchings <ben@...adent.org.uk>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>
Cc:	Nick Bowler <nbowler@...iptictech.com>, Greg KH <greg@...ah.com>,
	Dave Jones <davej@...hat.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Debian kernel maintainers <debian-kernel@...ts.debian.org>
Subject: Re: [PATCH] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging

On Wed, 07 Dec 2011 14:30:58 +0000, Ben Hutchings <ben@...adent.org.uk> wrote:
> We do want to allow lock debugging for GPL-compatible modules that are
> not (yet) built in-tree.  This was disabled as a side-effect of commit
> 2449b8ba0745327c5fa49a8d9acffe03b2eded69 ('module,bug: Add
> TAINT_OOT_MODULE flag for modules not built in-tree').  Lock debug
> warnings now include taint flags, so kernel developers should still
> be able to deflect warnings caused by out-of-tree modules.
> 
> The TAINT_PROPRIETARY_MODULE flag for non-GPL-compatible modules will
> still disable lock debugging.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

Meh.  Disabling lock debugging was always a weird thing to do, IMHO.
Taint flags should be used for warnings to developers, not these strange
side-effects.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/