linux-kernel - Re: [PATCH 09/30] Staging: comedi: fix printk issue in pcmuio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Dec 2011 14:29:46 +0100
From:	"Hans J. Koch" <hjk@...sjkoch.de>
To:	Ravishankar karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/30] Staging: comedi: fix printk issue in pcmuio.c

On Thu, Dec 08, 2011 at 06:22:04PM +0530, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the pcmuio.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
> 
> Added KERN_facility levels for printks.

You shouldn't use printk, use the dev_* macros, e.g. dev_warn, dev_err...

Thanks,
Hans

> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@...enturtles.in>
> ---
>  drivers/staging/comedi/drivers/pcmuio.c |   23 +++++++++++------------
>  1 files changed, 11 insertions(+), 12 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/