linux-kernel - Re: [PATCH] proc: remove superfluous debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111208192014.GA9794@albatros>
Date:	Thu, 8 Dec 2011 23:20:14 +0400
From:	Vasiliy Kulikov <segoon@...nwall.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Alexey Dobriyan <adobriyan@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: remove superfluous debug output

On Tue, Dec 06, 2011 at 16:48 -0800, Andrew Morton wrote:
> > -	pr_debug("proc: options = %s\n", options);
> > -
> >  	if (!options)
> >  		return 1;
> 
> So it turns out that this patch is a fix against the pending
> procfs-add-hidepid=-and-gid=-mount-options.patch.  Please tell people
> this sort of thing to prevent confusion.

Oops, sorry.  Will do this next time.


> Also, I have a note here that Alexey has issues with
> procfs-add-hidepid=-and-gid=-mount-options.patch (it is reproduced
> below) - he suggests that it is using incorrect types.  Where do we
> stand with that?

This is not a bug, surely.  IMHO, it's better to have it as the longest
possible format for the future changes.  It's wearily to find such %d
for pid_t instances all over the kernel if we change pid_t from int to
long.

The same question, btw:

http://www.spinics.net/lists/kernel/msg1270730.html

Probably it's better to add official point about this issue into
Documentation/ ?


Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/