linux-kernel - Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EE1C3E4.2060703@analog.com>
Date:	Fri, 9 Dec 2011 09:16:36 +0100
From:	Michael Hennerich <michael.hennerich@...log.com>
To:	Axel Lin <axel.lin@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michael Hennerich <hennerich@...ckfin.uclinux.org>,
	Naveen Kumar G <naveen.gaddipati@...ricsson.com>,
	Sundar Iyer <sundar.iyer@...ricsson.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"device-drivers-devel@...ckfin.uclinux.org" 
	<device-drivers-devel@...ckfin.uclinux.org>
Subject: Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols

On 12/09/2011 02:39 AM, Axel Lin wrote:
> These symbols are not used outside it's driver so no need to
> make the symbol global.
>
> Signed-off-by: Axel Lin<axel.lin@...il.com>
Acked-by: Michael Hennerich <michael.hennerich@...log.com>
> ---
>   drivers/input/keyboard/bf54x-keys.c         |    2 +-
>   drivers/input/keyboard/nomadik-ske-keypad.c |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
> index 683e314..8eb9116 100644
> --- a/drivers/input/keyboard/bf54x-keys.c
> +++ b/drivers/input/keyboard/bf54x-keys.c
> @@ -384,7 +384,7 @@ static int bfin_kpad_resume(struct platform_device *pdev)
>   # define bfin_kpad_resume  NULL
>   #endif
>
> -struct platform_driver bfin_kpad_device_driver = {
> +static struct platform_driver bfin_kpad_device_driver = {
>   	.driver		= {
>   		.name	= DRV_NAME,
>   		.owner	= THIS_MODULE,
> diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c
> index 6c4828f..5a71e55 100644
> --- a/drivers/input/keyboard/nomadik-ske-keypad.c
> +++ b/drivers/input/keyboard/nomadik-ske-keypad.c
> @@ -379,7 +379,7 @@ static const struct dev_pm_ops ske_keypad_dev_pm_ops = {
>   };
>   #endif
>
> -struct platform_driver ske_keypad_driver = {
> +static struct platform_driver ske_keypad_driver = {
>   	.driver = {
>   		.name = "nmk-ske-keypad",
>   		.owner  = THIS_MODULE,


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/