linux-kernel - Re: [PATCH 1/2] mfd: jz4740-adc: Include linux/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EE1E0D5.7080006@metafoo.de>
Date:	Fri, 09 Dec 2011 11:20:05 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 1/2] mfd: jz4740-adc: Include linux/io.h

On 12/09/2011 04:27 AM, Axel Lin wrote:
> Include linux/io.h to fix below build error:
> 
>   CC      drivers/mfd/jz4740-adc.o
> drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_irq_demux':
> drivers/mfd/jz4740-adc.c:73: error: implicit declaration of function 'readb'
> drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_set_enabled':
> drivers/mfd/jz4740-adc.c:110: error: implicit declaration of function 'writeb'
> drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_set_config':
> drivers/mfd/jz4740-adc.c:146: error: implicit declaration of function 'readl'
> drivers/mfd/jz4740-adc.c:151: error: implicit declaration of function 'writel'
> drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_probe':
> drivers/mfd/jz4740-adc.c:249: error: implicit declaration of function 'ioremap_nocache'
> drivers/mfd/jz4740-adc.c:249: warning: assignment makes pointer from integer without a cast
> drivers/mfd/jz4740-adc.c:289: warning: passing argument 3 of 'mfd_add_devices' discards qualifiers from pointer target type
> include/linux/mfd/core.h:93: note: expected 'struct mfd_cell *' but argument is of type 'const struct mfd_cell *'
> drivers/mfd/jz4740-adc.c:299: error: implicit declaration of function 'iounmap'
> make[2]: *** [drivers/mfd/jz4740-adc.o] Error 1
> make[1]: *** [drivers/mfd] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Lars-Peter Clausen <lars@...afoo.de>

> ---
>  drivers/mfd/jz4740-adc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index 1e9ee53..ef39528 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -16,6 +16,7 @@
>   */
>  
>  #include <linux/err.h>
> +#include <linux/io.h>
>  #include <linux/irq.h>
>  #include <linux/interrupt.h>
>  #include <linux/kernel.h>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/