linux-kernel - Re: [PATCH v3] NUMA x86: add constraints check for nid parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1112090219500.15325@chino.kir.corp.google.com>
Date:	Fri, 9 Dec 2011 02:44:17 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Petr Holasek <pholasek@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Anton Arapov <anton@...hat.com>
Subject: Re: [PATCH v3] NUMA x86: add constraints check for nid parameters

On Fri, 9 Dec 2011, Ingo Molnar wrote:

> Thanks guys.
> 
> Just to double check: there's no known instance of such a bad 
> SRAT in existence, so this commit can wait until v3.3 and does 
> hot have to go into v3.2, right?
> 

Andi mentioned buggy SRATs, but it's outside the scope of this patch; this 
has nothing to do with buggy SRATs.

Ignoring NUMA emulation which plays with these when you boot with 
numa=fake, this patch is catching any instance where pxm_to_node(x) 
returns NUMA_NO_NODE, meaning x is not an initialized pxm.  For x86, we 
initialize pxms by grabbing them from the SRAT, picking the first unused 
node id, and mapping them.  The SRAT has nothing to do with this, the ACPI 
spec has no notion of what we've defined a node to be.  So Petr's patch 
will simply catch any instance of pxm_to_node(x) where x was not 
initialized and incorrectly referencing 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/