linux-kernel - Re: [PATCH V2 1/2] xen/granttable: Support sub-page grants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EE1F0A6.1090704@oracle.com>
Date:	Fri, 09 Dec 2011 19:27:34 +0800
From:	annie li <annie.li@...cle.com>
To:	Paul Durrant <Paul.Durrant@...rix.com>
CC:	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	"jeremy@...p.org" <jeremy@...p.org>,
	"kurt.hackel@...cle.com" <kurt.hackel@...cle.com>,
	Ian Campbell <Ian.Campbell@...rix.com>
Subject: Re: [PATCH V2 1/2] xen/granttable: Support sub-page grants



On 2011-12-9 16:48, Paul Durrant wrote:
>> -----Original Message-----
>> From: Ian Campbell
>> Sent: 09 December 2011 08:37
>> To: annie li
>> Cc: Paul Durrant; xen-devel@...ts.xensource.com; linux-
>> kernel@...r.kernel.org; konrad.wilk@...cle.com; jeremy@...p.org;
>> kurt.hackel@...cle.com
>> Subject: Re: [PATCH V2 1/2] xen/granttable: Support sub-page grants
>>
>> On Fri, 2011-12-09 at 07:45 +0000, annie li wrote:
>>     
>>> On 2011-12-9 13:19, annie li wrote:
>>>       
>>>> Hi Paul,
>>>>
>>>>         
>>>>>>> #define get_free_entry()    get_free_entries(1)
>>>>>>>               
>>>> Is this necessary? Maybe you defined this to keep consistence
>>>>         
>> with
>>     
>>>> put_free_entry(ref)?
>>>> But other functions such as gnttab_grant_foreign_transfer and
>>>> gnttab_grant_foreign_access all call get_free_entries(1). Maybe
>>>>         
>> it
>>     
>>>> is better to keep initial get_free_entries(1) code?
>>>>         
>>> Another approach is doing those work in a separate patch --
>>>       
>> changing
>>     
>>> get_free_entries to get_free_entry in following 4 functions:
>>>       
>> I think you shouldn't get too bogged down in get_free_entry() vs
>> get_free_entries(1) for the purposes of this patch series.
>>
>>     
>
> Annie,
>
>   Yes, don't worry about get_free_entry(). I only defined it for the sake of symmetry in the code I posted.
>   
OK, will keep get_free_entries(1) unchanged.

Thanks
Annie
>   Paul
>   
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/