linux-kernel - Re: [PATCH] apparmor: add missing rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EE15B39.9050302@canonical.com>
Date:	Thu, 08 Dec 2011 16:50:01 -0800
From:	John Johansen <john.johansen@...onical.com>
To:	Kees Cook <keescook@...omium.org>
CC:	linux-kernel@...r.kernel.org, James Morris <jmorris@...ei.org>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH] apparmor: add missing rcu_dereference()

On 12/08/2011 04:25 PM, Kees Cook wrote:
> Adds a missed rcu_dereference() around real_parent.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  security/apparmor/audit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c
> index 96502b2..f3fafed 100644
> --- a/security/apparmor/audit.c
> +++ b/security/apparmor/audit.c
> @@ -133,7 +133,7 @@ static void audit_pre(struct audit_buffer *ab, void *ca)
>  		struct aa_profile *profile = sa->aad.profile;
>  		pid_t pid;
>  		rcu_read_lock();
> -		pid = tsk->real_parent->pid;
> +		pid = rcu_dereference(tsk->real_parent)->pid;
>  		rcu_read_unlock();
>  		audit_log_format(ab, " parent=%d", pid);
>  		if (profile->ns != root_ns) {
yep.

Acked-by: John Johansen <john.johansen@...onical.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/