linux-kernel - Re: [alsa-devel] [PATCH 2/5] ASoC: mxs: add .owner to struct snd_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20194.7382.414612.182139@ipc1.ka-ro>
Date:	Fri, 9 Dec 2011 15:36:06 +0100
From:	Lothar Waßmann <LW@...O-electronics.de>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	alsa-devel@...a-project.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Dong Aisheng-B29396 <B29396@...escale.com>,
	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [alsa-devel] [PATCH 2/5] ASoC: mxs: add .owner to struct
 snd_soc_card

Hi,

Wolfram Sang writes:
> On Fri, Dec 09, 2011 at 02:38:09PM +0100, Lothar Waßmann wrote:
> > This will prevent the module from being removed from underneath its
> > users
> > 
> > Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>
> 
> I can't find any other instance setting owner in snd_soc_card?
> 
Then that other uses are most probably faulty too.

You can easily test it by loading all necessary sound modules,
starting some application that uses the sound device (e.g. alsamixer)
and then removing the snd-soc-mxs-sgtl5000 module.

Without the patch the removal will succeed crashing the
application. With this patch the refcount of the module will be
> 0 as long as an application is using it, preventing the
removal.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@...o-electronics.de
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/