linux-kernel - Re: [PATCH 1/1] USB: Adding #define in hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1112091040040.1656-100000@iolanthe.rowland.org>
Date:	Fri, 9 Dec 2011 10:42:18 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Aman Deep <amandeep3986@...il.com>
cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Robert Morell <rmorell@...dia.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Andiry Xu <andiry.xu@....com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] USB: Adding #define in hub_configure() and hcd.c
 file

On Thu, 8 Dec 2011, Aman Deep wrote:

> This patch is in succession of previous patch
> commit c8421147926fcacf53081a36438a0bed394da9f5
>         xHCI: Adding #define values used for hub descriptor
> 
> Hub descriptors characteristics #defines values are added in
> hub_configure() in place of magic numbers as asked by Alan Stern.
> And the indentation for switch and case is changed to be same.
> 
> Some #defines values are added in ch11.h for defining hub class
> protocols and used in hub.c and hcd.c in which magic values were
> used for hub class protocols.
> 
> Signed-off-by: Aman Deep <amandeep3986@...il.com>

I like it!

If you're looking for more things to work on, consider the #defines in
ch11.h for the various port features and statuses.  Some of the newer
USB-3 entries were added in the wrong place, or even added twice!  It
would be good to get that straightened up.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/